search

LuigiBlood / sat_wave

SatellaWave
MIT License
66 stars 8 forks source link

Event Plaza Collision Bug #26

Closed Mekeninzo closed 4 months ago

Mekeninzo commented 4 months ago

As I've been using the Event Plaza Editor to restore some of the recently released Plazas on Satella blog I'm noticing the "Over the player" Collision checkbox does not work for tiles located in the bottom half of the Collision editor for some reason. Not sure if this is an intended feature, but it doesn't seem like it should work like that.

Starting with the top left corner and counting left to right, tiles 1-28 work fine. Tiles 29-47 do not. Tile 48 doesn't even allow a tile to be saved in this spot.

Most of the time I can work around this by moving tile locations. Only problem is the Sim building because it uses so many tiles. (I need an extra 2 tile slots)

I've also noticed times where "Over the player" is unchecked and moving off the tile puts the player under that tile. Moving the tile to another spots fixes this issue, so it's only a bit annoying.

I'll look through the code when I have time and see if I can figure out why this is happening.

LuigiBlood commented 4 months ago

I totally think it's a bug on BS-X because I don't see anything wrong in SatellaWave. I need to look into it more but I don't know what causes the bug.

Mekeninzo commented 4 months ago

Ok so I think I have some reason why this is happening and I think it's because the Map size is only 112 Pixels Tall.

tiles 1-28 is 7 tiles tall if you stack them on top of each other assuming a width of 4 tiles (7 x 16 = 112) (4 x 16 = 64) which is max pixel height for map that you are allowed to load despite the tile map being 12 pixels tall in total (12 x 16 = 192). I could be wrong though.

Further research is required.

LuigiBlood commented 4 months ago

Found the issue. The priority bit isn't set for the tile map info.

LuigiBlood commented 4 months ago

By the way, the last tile not being taken into account is I believe because BS-X is buggy with it.

LuigiBlood commented 4 months ago

This should be fixed now. https://github.com/LuigiBlood/sat_wave/commit/60b27ef1b27a80e03ccf54d4ad5da39ac159e8e0

Mekeninzo commented 4 months ago

Awesome! Thanks dawg. I'll test this out when I get home

Mekeninzo commented 4 months ago

Test Complete. This works great now! Issue Closed