search

LuisMayo / objection_engine

Library that turns comment chains into ace attorney scenes, used in several bots
MIT License
105 stars 20 forks source link

"Testimony" flashing label #114

Closed Meorge closed 1 year ago

Meorge commented 1 year ago

This pull request allows users to place a flashing label in the top-left corner of the screen to indicate that a specific sequence is in progress. In the original games, this would appear on-screen as "Testimony" during a Witness Testimony segment. Using commands, the user can customize the string, text fill color, and text stroke color.

https://github.com/LuisMayo/objection_engine/assets/9957987/1c44f0ac-f721-4ba0-8398-02be9669eb4a

To use this feature, the the testimony_indicator folder, available for download here, will need to be placed inside the assets folder.

LuisMayo commented 1 year ago

I'm not sure if I'm doing anything wrong but it doesn't work for me, errors are thrown in the terminal and the video does not include the indicator imagen

Meorge commented 1 year ago

Hm, that's quite strange... I can see in the branch that the code should be there for detecting the "testimony" command. Are you sure you installed the updated version of the engine using pip and/or poetry? It may be that Python is using an old version of the engine instead of the freshly downloaded one... that's happened to me a few times before 😅

LuisMayo commented 1 year ago

You were right.

This is good to go!