search

LuisMayo / objection_engine

Library that turns comment chains into ace attorney scenes, used in several bots
MIT License
107 stars 20 forks source link

Add resolution scaling parameter #66

Closed legoandmars closed 2 years ago

legoandmars commented 2 years ago

On Discord (and likely other platforms), the relatively low resolution of the video can make embeds small and lead to blurriness when in fullscreen.

Although more complex solutions have been outlined in #12, this is a quick & easy way to make the video more high resolution without losing sharpness by just using nearest neighbor scaling.

Scaling is passed through the resolution_scale parameter in the render_comment_list method. Old scaling (1:1) is retained by default

Discord Example

LuisMayo commented 2 years ago

Hi! Thanks a lot for the PR. This will likely be implemented in my three versions of the bot (Twitter, Discord, Telegram). Bots will be likely updated thorough the day.

Again thanks for the request, video quality has been terrible since day 1, it's a bit more bearable now ^^