Closed saschanaz closed 2 years ago
render_comment_list([Comment(text_content="音声合成ソフトVOCALOIDをボーカルに用いたオリジナル楽曲を発表している音楽プロデューサー、ボカロP。別名は蜜柑星P。配偶者はクリエイターの夏背。 ")], output_filename="output.mp4")
Before:
After:
(That vertical overflow should be fixed separately, perhaps in #73)
I'm AFK right now. I'll check in the following days. Thank you very much for the PR, this was something I wanted to do for a while
This does NOT close #55 , it only addresses a comment in that issue. However this works and fix Japanese and other non-whitespace languages so I'm really grateful for that. Thanks!
This does NOT close #55 , it only addresses a comment in that issue. However this works and fix Japanese and other non-whitespace languages so I'm really grateful for that. Thanks!
Does #73 covers that?
Well, you opened #73 so you're the one to evaluate whether it's fixed or not. So feel free to close that issue. I'd think it's fixed yeah
The vertical overflow thing in https://github.com/LuisMayo/objection_engine/pull/74#issuecomment-1114307436 is about #73, and I think that's the only remaining part of #55, or is there anything else?
Sounds like that's still about comments_to_scene, fixing one should ideally fix another. But let's keep them for now, thanks!
Thank YOU :-)
Closes #55
(Actually I think the op of #55 is more about https://github.com/LuisMayo/objection_engine/issues/73#issuecomment-1114305732 rather than the comment below, but anyway...)