search

LuisMayo / objection_engine

Library that turns comment chains into ace attorney scenes, used in several bots
MIT License
105 stars 20 forks source link

Migrate to pyproject to be a library #75

Closed saschanaz closed 2 years ago

saschanaz commented 2 years ago

Closes #19

LuisMayo commented 2 years ago

I've given this a test. It seems to work after I've changed an import as you can see. There are a couple of problems though.

  1. It currently is conflicting main branch
  2. It can be installed using the git URL, which is fine by me, but this can't be uploaded to pypi since it has an URL dependency (xx-ent-wiki-sm). To fix this we would have to either add functionality to download xx-ent-wiki-sm from within the code or replace spacy entirely.

So, to clarify things, for this PR to be merged it's fine if only point 1 is fixed, point 2 is not necessary for me. But if you want me to upload this to pypi it should be fixed too.

Thanks!

saschanaz commented 2 years ago

For now the git URL is also fine for my use. Perhaps the spacy thing can be done separately to limit the scope of this PR.

LuisMayo commented 2 years ago

This seems good to go now. Thanks a lot for the PR and for the patience you've shown during it.