LuisMayo / objection_engine

Library that turns comment chains into ace attorney scenes, used in several bots
MIT License
105 stars 20 forks source link

Nameplate changes width to fit name and uses different font #90

Closed Meorge closed 1 year ago

Meorge commented 1 year ago

This pull request implements two improvements to rendering:

To do the dynamic nameplate sizing, I did my best to recreate the dialogue box based on screenshots from the original DS games.

Here is a screenshot of a quick test dialogue before the pull request: Screen Shot 2022-10-22 at 8 56 22 PM

And this is what the same dialogue looks like with these changes:

Screen Shot 2022-10-22 at 9 10 23 PM

In order for this to work, some additional assets will need to be added to the assets folder. This zip file includes:

They should just need to be placed in the assets folder (with the exception of the .afphoto file; it's just there so we can edit it later :) )

I've tested this with the example.py file as well as a few of my own short scripts, and it seems to be working well, but of course it'd be great to have other checks done before merging so it doesn't break anything.

Thanks so much!

LuisMayo commented 1 year ago

This seems fine. I'll give a test and merge if it's working good

LuisMayo commented 1 year ago

And done. Thanks a lot, the bots are going to look so much better thanks to your work :)