search

Luismahou / grunt-hashres

Hashes your js and css files and rename the <script> and <link> declarations that refer to them in your html/php/etc files.
MIT License
115 stars 41 forks source link

Update hashresHelper.js - error when replaces references to the given fi... #21

Closed DaWyz closed 10 years ago

DaWyz commented 10 years ago

...les with the hashed ones

There was an issue when i had 2 images with names like "es.png" and "states.png" (same ending). "es.png" name matches for both images if "states.png" name isn't already replaced by the hashed name.

Luismahou commented 10 years ago

Thanks for your contribution DaWyz, but I cannot accept changes in package.json.

martint17r commented 10 years ago

This bug is biting me too - @Luismahou - would you accept another patch for this without the package.json modification?

@DaWyz: would you mind if I cherry pick your revision db166a5?

DaWyz commented 10 years ago

hey, i'm sorry. I just don't understand why the package.json was include in the pull request, i sent it before modifing this package.json (i'm new with GitHub). My previous company is still using my fork, so i could fork your grunt-hashres again an make a clean pull request if it's ok for you.

Luismahou commented 10 years ago

This is fixed in version 0.4.1