search

LuizArmesto / backbone.leaflet

A map component for Backbone.js
MIT License
54 stars 16 forks source link

Gracefully fail when leaflet is not loaded #6

Closed devel-pa closed 10 years ago

devel-pa commented 10 years ago

"Uncaught ReferenceError: L is not defined" on the last line of the file.

LuizArmesto commented 10 years ago

Are you trying to use GeoJSON with backbone without the map view? If the answer is yes you might be interested in issue #5.

The way it was originally implemented is dependent on leaflet. I'm working to separate the model and collection code from the map view code to be possible to use them independently without leaflet.

Otherwise, suggestions are welcome.

devel-pa commented 10 years ago

No, I'm trying to use the application offline, so, leaflet library is not loaded. I don't have a suggestion, yet. For the moment I put your library inside 

         if(typeof L != "undefined")
zedd45 commented 10 years ago

@devel-pa I'm also doing an offline application, but Leaflet can be a local dependency I'm not sure what your use case is, but could you just include leaflet off your filesystem?

I'm using a browserify bundle, so for me this only requires two things: at the terminal:

npm install

in my main.js:

require('leaflet');
LuizArmesto commented 10 years ago

I agree with @zedd45. Add Leaflet as a local dependency is the best solution.

Closing for now. Please fell free to reopen this issue if this solution doesn't fit your needs.