search

LukWebsForge / ShareIt

Two Intellij IDEA plugins for uploading code / files to hastebin and Discord
MIT License
10 stars 4 forks source link

Update import for GithubGistRequest.FileContent #8

Closed iasemenov closed 5 years ago

iasemenov commented 5 years ago

Package request was moved under data two weeks before the plugin was released.

lukbukkit commented 5 years ago

Thanks for your pull request. The GitHub plugin is a bundled plugin. So if I'm correct, its version depends on the IDE version or? Is there a recommend way to support older and newer IDE versions at once, maybe different classes or services for different versions of the GitHub plugin?

iasemenov commented 5 years ago

Yes, you are correct - version of GitHub plugin depends on version of IDE. As for compatibility - it is advised to correctly set the compatible versions and check/update the plugin when new IDE version is released. We don't usually break the existing APIs, so usually it doesn't require much effort, but in this case it was not possible to check since plugin was not released yet.

lukbukkit commented 5 years ago

Ah thanks for the explanation, I get the problem now. I guess, I'll merge this pull request and then build for this special case an adapter for the older and the newer versions of the GitHub plugin, so that this plugin can mantain backwards compatilbity.

lukbukkit commented 5 years ago

Thanks a lot for your help!