Luka967 / OgarII

FOSS implementation of a private Agar.io gameserver, made with Node.js.
Other
67 stars 38 forks source link

Okay, so does OgarII have skins #11

Closed Niall7459 closed 6 years ago

Niall7459 commented 6 years ago

I'm assuming not looking at the source code

SuperOP535 commented 6 years ago

"DON'T go around asking how do I do this how do I do that. You have the MultiOgar-Edited Discord guild for that."

Read the README kthx, this is not a "how do I do this" question but it is a similar one

AlexHGaming commented 6 years ago

@SuperOP535 I do not understand why you would need to use the MO-E guild for a different repo. OgarII is different.

xAzz commented 6 years ago

@AlexHGaming This is based off MO-E. Its just a rewrite of it but practically the same thing lol..

AlexHGaming commented 6 years ago

for a different repo

Niall7459 commented 6 years ago

Yes being a different repo will cause all sorts of problems in the same discord server such as "error" i cant reproduce "error" because the two server types

retroscepter commented 6 years ago

@alexhgaming don’t be a dick, the MO-E Discord is for assistance with most open source projects within the metaphorical network of people and things around MO and MO-E.

AlexHGaming commented 6 years ago

@vaporpalm But I thought in the discord it said no help with custom code or some shit like that.

retroscepter commented 6 years ago

@alexhgaming Custom code refers to modified versions of open source projects involved in the network i was talking about, like MO and MO-E. A good example would be MO-Unlimited. OgarII would be allowed since it is an active project of Luka’s, who is one of the primary developers in this network of people. He also stated directly in the read me that support for OgarII will be handled in the MO-E Discord. He doesn’t have to give you a reason why, that’s just how it is.

AlexHGaming commented 6 years ago

Alright then, now I understand.

SuperOP535 commented 6 years ago

@AlexHGaming I just copied from the README boi

AlexHGaming commented 6 years ago

k

SuperOP535 commented 6 years ago

Also, skins are handled by the client so I don't know how this relates to a server

Luka967 commented 6 years ago

This is client-related however there's no support for skins enclosed with <> like MO-E has. I might add it in the future. Closing because of inactivity

Niall7459 commented 6 years ago

How to put a skin into a name then is it with % or what

I use OGarII

SuperOP535 commented 6 years ago

@Niall7459 Can't you just get it, it depends on the client. If you use Cigar2 then just use the skin selector/skin input box

Niall7459 commented 6 years ago

This is about the server. The server does not handle skins, looking at the source code, skins are parsed as null objects, this should not be the case, skins should be handled on the server side like in legacy implementations through the variables that are already there.

If there is a skin field in packet node add/update then why should it not be used? This breaks the compatibility with older clients and is generally bad practice.

On 3 Jun 2018, at 15:25, SuperOP535 notifications@github.com wrote:

@Niall7459 Can't you just get it, it depends on the client. If you use Cigar2 then just use the skin selector/skin input box

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

SuperOP535 commented 6 years ago

The only thing the server has to do with skins is to not count them in name length.

retroscepter commented 6 years ago

OgarII is abandoned, let it go.

freaky767 commented 6 years ago

not anymore ^

Niall7459 commented 6 years ago

I added a MultiOgar-Edited bracket skin system but I’m assuming luka will keep the curly bracket system with skins inside names to keep support for Cigar2 etc

Closed