search

LukasBanana / LLGL

Low Level Graphics Library (LLGL) is a thin abstraction layer for the modern graphics APIs OpenGL, Direct3D, Vulkan, and Metal
BSD 3-Clause "New" or "Revised" License
2.03k stars 135 forks source link

Fix some warnings under `/W4` #105

Closed duckdoom4 closed 5 months ago

duckdoom4 commented 6 months ago

title

duckdoom4 commented 6 months ago

Sorry for the late reply. I'll address your pointers. I found some more warnings, so I might add some more fixes before that though. Bit bussy today so I'll try to find some time later

LukasBanana commented 5 months ago

Do you still intend to update this PR or can we close this one since it doesn't compile on some platform configurations?

duckdoom4 commented 5 months ago

Ah right, forgot about this one. There are still some other warnings so I would like to get them fixed at some point.

That said I think the warnings in this PR have been fixed by you already right? So I can always make a new PR later. I'll leave that up to you.

LukasBanana commented 5 months ago

Closing since the warnings in this PR have been addressed in separate commits. Feel free to open a new PR if you have new fixes.