Fix crash in D3D12 when using LLGL::RenderingDebugger.

LukasBanana / LLGL

Low Level Graphics Library (LLGL) is a thin abstraction layer for the modern graphics APIs OpenGL, Direct3D, Vulkan, and Metal

BSD 3-Clause "New" or "Revised" License

2.05k stars 139 forks source link

Fix crash in D3D12 when using LLGL::RenderingDebugger. #113

Closed gdianaty closed 4 months ago

gdianaty commented 4 months ago

Caught this mistake (that I made) while tinkering tonight.

It's exactly what it says on the tin: when using LLGL::RenderingDebugger, LLGL will attempt to reflect into the shader. Without LLGL_D3D12_ENABLE_DXCOMPILER, a crash occurs.

Crash was due to a lack of graceful HRESULT handling.

LukasBanana commented 4 months ago

Looks good to me. Thanks for fixing this.