reserved identifier violation

LukasBanana / LLGL

Low Level Graphics Library (LLGL) is a thin abstraction layer for the modern graphics APIs OpenGL, Direct3D, Vulkan, and Metal

BSD 3-Clause "New" or "Revised" License

2.05k stars 139 forks source link

reserved identifier violation #2

Closed elfring closed 7 years ago

elfring commented 7 years ago

I would like to point out that an identifier like "__LLGL_COMMAND_BUFFER_H__" does not fit to the expected naming convention of the C++ language standard. Would you like to adjust your selection for unique names?

LukasBanana commented 7 years ago

Thank's for the hint, I always used this identifier syntax in my projects and with the repsective Project name prefix (here "LLGL_") I never had a problem with that. But I will fix this as soon as possible.

oleid commented 7 years ago

How about using a "#pragma once" instead of a preprocessor guard?

LukasBanana commented 7 years ago

I know "#pragma once" is implemented in most C++ compilers, but since it's not part of the C++ standard, I'd like to use header guards instead.

LukasBanana commented 7 years ago

Renamed all header guards from "LLGL_..._H" to "LLGL_..._H".

elfring commented 7 years ago

Thanks for your improvement of affected identifiers.