search

LukasBanana / LLGL

Low Level Graphics Library (LLGL) is a thin abstraction layer for the modern graphics APIs OpenGL, Direct3D, Vulkan, and Metal
BSD 3-Clause "New" or "Revised" License
2.03k stars 135 forks source link

Added missing throw and reserve ShadingLanguages for fast insert #78

Closed GermanAizek closed 1 year ago

GermanAizek commented 1 year ago

@LukasBanana hi, Didn't you forget throw parameters? The exception will not fully work on any compilers and added reserve size for fast push_back().

LukasBanana commented 1 year ago

Hi, I actually noticed this just a few days ago but haven't submitted my change yet. I'm happy to take your PR though if you can also add the throw statements to ColorRGB and squash your commits. Thanks Laura

GermanAizek commented 1 year ago

No problem, I'll do it now.

GermanAizek commented 1 year ago

New commit here: https://github.com/LukasBanana/LLGL/pull/78/commits/4f13e0c6470054781f5af966bb699ffbe10c1599