Correctly parse headTemp using convert_3_char_to_U24P16

LukasBombach / de1

JavaScript API for the DE1 Espresso Machine

MIT License

21 stars 0 forks source link

Correctly parse headTemp using convert_3_char_to_U24P16 #16

Closed oscar-b closed 4 years ago

oscar-b commented 4 years ago

Needs some tests :)

oscar-b commented 4 years ago

How do we handle a corrupt Bluetooth packet? Is there a checksum? If not, I guess we should at least check the length of each packet so that a parser doesn't have to worry about bad data.

oscar-b commented 4 years ago

Had a quick chat with John about checksumming. They have none and rely on BLE to handle that. Doesn’t seem like it’s been a problem. Was thinking we could easily drop packets of the incorrect length though.