Check package length in parser

LukasBombach / de1

JavaScript API for the DE1 Espresso Machine

MIT License

20 stars 0 forks source link

Check package length in parser #19

Open oscar-b opened 4 years ago

oscar-b commented 4 years ago

We should have a basic packet length check when parsing incoming BLE packets.

There’s no checksum in the packets.

LukasBombach commented 4 years ago

:+1:

LukasBombach commented 4 years ago

Maybe we can have validation in some cases, like when we know the value can't be right or something

LukasBombach commented 4 years ago

Should this be required for the first release?

oscar-b commented 4 years ago

Not unless we have huge problems with corruption, I think. Others might have more problems with interference though, which might cause issues, who knows.