LukasGrebe / ha-addons

Addons for Home Assistant
GNU General Public License v3.0
43 stars 49 forks source link

Issue since upgrade to 23.2.4 #114

Closed fifinski closed 7 months ago

fifinski commented 7 months ago

Hello, Since i upgraded and restarted eBUSD on newest HomeAssistant i have a problem with starting addon: Addon is still telling me : Missing option 'mode' in root in eBUSd (2ad9b828_ebusd). This option is not/was not needed in previous releases. For now - no matter which option from available ( enh ens udp ) i will choose, ebus is not connecting with a device.

Thanx for helping.

tjorim commented 7 months ago

Please select the correct protocol/mode and update the network_device to not include it (thus only IP address and port).

fifinski commented 7 months ago

Hello @tjorim

My config is :

scanconfig: true loglevel_all: notice mqtttopic: ebusd mqttint: /etc/ebusd/mqtt-hassio.cfg mqttjson: false network_device: 192.168.0.23:9999 latency: 10 mqtthost: 192.168.0.20 mqttport: 1883 mqttpass: password mqttuser: mqtt-user pollinterval: 5 accesslevel: "*" mode: udp

And i got many errors ( for other mode options it makes many errors ):

2024-04-12 16:52:00.489 [mqtt error] read message bai PrEnergySumHc1 not found 2024-04-12 16:52:00.522 [mqtt error] read message bai PrEnergySumHwc1 not found 2024-04-12 16:52:00.524 [mqtt error] read message bai PrEnergySumHc1 not found 2024-04-12 16:52:00.525 [mqtt error] read message bai ReturnTemp not found 2024-04-12 16:52:00.532 [mqtt error] read message bai ReturnTempExternal not found 2024-04-12 16:52:00.533 [mqtt error] read message bai WaterPressure not found 2024-04-12 16:52:00.533 [mqtt error] read message bai FlowTemp not found 2024-04-12 16:52:00.533 [mqtt error] read message bai FlowTempDesired not found 2024-04-12 16:52:00.541 [mqtt error] read message bai HwcTemp not found 2024-04-12 16:52:00.541 [mqtt error] read message bai HwcTempMax not found 2024-04-12 16:52:00.545 [mqtt error] read message bai HwcWaterflowMax not found 2024-04-12 16:52:00.548 [mqtt error] read message 700 HwcTempDesired not found 2024-04-12 16:52:00.555 [mqtt error] read message 700 HwcOpMode not found 2024-04-12 16:52:00.560 [mqtt error] read message bai StorageTemp not found 2024-04-12 16:52:00.564 [mqtt error] read message bai PositionValveSet not found 2024-04-12 16:52:00.567 [mqtt error] read message bai PartloadHcKW not found 2024-04-12 16:52:00.572 [mqtt error] read message bai ModulationTempDesired not found 2024-04-12 16:52:00.576 [mqtt error] read message bai PumpPower not found 2024-04-12 16:52:00.580 [mqtt error] read message bai PrEnergyCountHc1 not found 2024-04-12 16:52:00.585 [mqtt error] read message bai PrEnergyCountHwc1 not found 2024-04-12 16:52:00.590 [mqtt error] read message bai averageIgnitiontime not found 2024-04-12 16:52:00.593 [mqtt error] read message bai FanSpeed not found 2024-04-12 16:52:00.596 [mqtt error] read message bai TargetFanSpeed not found 2024-04-12 16:52:00.601 [mqtt error] read message bai TargetFanSpeedOutput not found 2024-04-12 16:52:00.608 [mqtt error] read message bai currenterror not found 2024-04-12 16:52:00.611 [mqtt error] read message bai HeatingSwitch not found 2024-04-12 16:52:00.616 [mqtt error] read message bai Flame not found 2024-04-12 16:52:00.619 [mqtt error] read message bai Ignitor not found 2024-04-12 16:52:00.623 [mqtt error] read message bai WP not found 2024-04-12 16:52:00.628 [mqtt error] read message bai HwcSwitch not found 2024-04-12 16:52:00.633 [mqtt error] read message bai HwcDemand not found 2024-04-12 16:52:00.638 [mqtt error] read message bai HeatingSwitch not found 2024-04-12 16:52:00.643 [mqtt error] read message 700 HwcSFMode not found 2024-04-12 16:52:00.651 [mqtt error] read message 700 OpMode not found 2024-04-12 16:52:00.654 [mqtt error] read message 700 SFMode not found 2024-04-12 16:52:00.659 [mqtt error] read message 700 z1DayTemp not found 2024-04-12 16:52:00.663 [mqtt error] read message 700 z1NightTemp not found 2024-04-12 16:52:00.668 [mqtt error] read message 700 Hc1HeatCurve not found 2024-04-12 16:52:00.672 [mqtt error] read message 700 z1RoomTemp not found 2024-04-12 16:52:00.678 [mqtt error] read message bai OutdoorstempSensor not found

tjorim commented 7 months ago

That's not related to the add-on but ebusd itself (so out of scope).

RoSulek1 commented 7 months ago

That's not related to the add-on but ebusd itself (so out of scope).

I have the same error, because we use clean (TCP) protocole - then the device string is clean - without ENS, UDP or ENH image

albertsj commented 7 months ago

Running ebusd without a „mode“ is a valid option for serial devices. See https://github.com/john30/ebusd/wiki/2.-Run#device-options

RoSulek1 commented 7 months ago

Running ebusd without a „mode“ is a valid option for serial devices. See https://github.com/john30/ebusd/wiki/2.-Run#device-options

Exactly. But until version 23.2.3 the MODE parameter was not required. Now it is required and the add-on in this version 23.2.4 has become unusable for some users

hvorragend commented 7 months ago

Same problem here. ens, enh and udp are just optional.

You can see here that we need another (a default) value: https://github.com/john30/ebusd/wiki/2.-Run

DEVICE for serial device (e.g. /dev/ttyUSB0, for all other serial adapters like adapter v2 as well as non-enhanced mode), or

fifinski commented 7 months ago

I have just downgraded to previous version ...

henkela commented 7 months ago

Same here. Local USB Connection. Configuration forces selection of mode which produces --device=ens:/dev/ttyUSB0 Where it should just be --device=/dev/ttyUSB0

Please either make mode optional again or add an option for this case.

tjorim commented 7 months ago

I did not know the option was enforced now, I opened a PR to fix it: https://github.com/LukasGrebe/ha-addons/pull/116

pvyleta commented 7 months ago

Apologies, I was not aware the mode is only relevant for network connection. I added it to be mandatory to make it more straightforward for network connections, not realising I am breaking it for serial connection.

Kentrp commented 7 months ago

I have just downgraded to previous version ...

Hi! How did you do it? Explain me. Thk

fifinski commented 7 months ago

@Kentrp

You need to have backup made during upgrade

xjols commented 7 months ago

Same problem here with the required mode after upgrade. I used TCP connection until last version, without mode selection using https://github.com/danielkucera/esp-arduino-ebus ebus wifi server interface that not suport UDP. I swiched to enh mode but I have some bus errors in enhanced

xjols commented 7 months ago

I think that in mode selection configuration page of the add-on, with the options enh, ens and udp needs another four otion with "default". In previous add-on versions, none of the options are selected by default. If you selected any of the options, it can't not be unselected, and only have option to select any of the other options, but not none. And in this case the only option to return to default "none" option is "return to default settings".

dmarczydlo commented 7 months ago

@tjorim when can we get the new version without the required mode?

tjorim commented 7 months ago

I needed one more approval of a contributor which just happened. PR has been merged and the update is available. After updating you will need to remove the mode option by clicking on the three dots and selecting Edit in YAML. Screenshot_20240416-093039.png

dmarczydlo commented 7 months ago

@tjorim awesome!. Great job!

Kentrp commented 7 months ago

@tjorim, now work correct 👍