LukasGrebe / ha-addons

Addons for Home Assistant
GNU General Public License v3.0
43 stars 49 forks source link

enablehex missing in the boolean options #128

Closed thomaskilian closed 5 months ago

thomaskilian commented 5 months ago

In order to have ebusd started with enablehex, this option needs to be added to the boolean options in run.sh

LukasGrebe commented 5 months ago

Why not use the custom parameters?

thomaskilian commented 5 months ago

I tried adding it to the config, but it was ignored. To me it looked like run.sh needs to know about enablehex

This is my cfg:
scanconfig: true
loglevel_all: info
mqtttopic: ebusd
mqttint: /config/ebusd/mqtt-hassio.cfg
mqttjson: true
network_device: ens:192.168.2.136:9999
configpath: /config/ebusd/config
accesslevel: "*"
logdir_name: /config/ebusd/logs
lograwdata: false
mqttuser: mqtt
mqttpass: xxxx
enablehex: true

Not working:

2ad9b828-ebusd:/# ebusctl hex 23
ERR: command not enabled
LukasGrebe commented 5 months ago

Try

commandline_options: "--enablehex"

Instead of

enablehex: true

thomaskilian commented 5 months ago

That works. Though the logic seems to suggest using my first attempt. Unfortunately I neither speak Polish nor Czech, so aa pull does not seem to make much sense...

LukasGrebe commented 5 months ago

I stopped adding command line options or flags as explicit fields in the addon settings and figured Power users can use the custom field for anything advanced.

thomaskilian commented 5 months ago

Guess, you are right in doing so :-)