LukasGrebe / ha-addons

Addons for Home Assistant
GNU General Public License v3.0
37 stars 42 forks source link

RFC - Remove foreground option #14

Closed tim-devel closed 2 years ago

tim-devel commented 2 years ago

We currently have a boolean that allows the user to choose if eBUSd runs in the foreground or not. If the user switches this boolean off run.sh throws the following warning:

if bashio::config.false "foreground" || bashio::config.is_empty "foreground"; then
    bashio::config.suggest.true "foreground" "ebusd add-on will stop if ebusd is not running in the foreground."
fi

If the add-on will not run properly with foreground switched off then I propose that we remove this option and have foreground switched on by default and not user configurable.

I will raise a pull request once my other changes have been reviewed.

LukasGrebe commented 2 years ago

That probably makes more sense. I'm pretty sure this is a development artifact

tim-devel commented 2 years ago

18