LukasGrebe / ha-addons

Addons for Home Assistant
GNU General Public License v3.0
41 stars 46 forks source link

WIP - Network adapter support #19

Closed tim-devel closed 2 years ago

tim-devel commented 2 years ago

Add support for network eBUSd adapter

To-do:

pepsonEL commented 2 years ago

I think that name wireless_device should be change to network_device becuse we can use wemos d 1 mini (wireless) or LAN adapter and it also works. This

smd-3dwifi

or this smd-3dethernet

tim-devel commented 2 years ago

Good point, I will amend

On Wed, 12 Jan 2022, 3:16 pm pepsonEL, @.***> wrote:

I think that name wireless_device should be change to network_device becuse we can use wemos d 1 mini (wireless) or LAN adapter and it also works.

— Reply to this email directly, view it on GitHub https://github.com/LukasGrebe/ha-addons/pull/19#issuecomment-1011149107, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABUDLZXK3ID6S7SQGXEJZ5TUVWLMBANCNFSM5LZD3XIA . You are receiving this because you authored the thread.Message ID: @.***>

pepsonEL commented 2 years ago

Thanks. When released i start test

śr., 12 sty 2022, 17:42 użytkownik Tim @.***> napisał:

Good point, I will amend

On Wed, 12 Jan 2022, 3:16 pm pepsonEL, @.***> wrote:

I think that name wireless_device should be change to network_device becuse we can use wemos d 1 mini (wireless) or LAN adapter and it also works.

— Reply to this email directly, view it on GitHub <https://github.com/LukasGrebe/ha-addons/pull/19#issuecomment-1011149107 , or unsubscribe < https://github.com/notifications/unsubscribe-auth/ABUDLZXK3ID6S7SQGXEJZ5TUVWLMBANCNFSM5LZD3XIA

. You are receiving this because you authored the thread.Message ID: @.***>

— Reply to this email directly, view it on GitHub https://github.com/LukasGrebe/ha-addons/pull/19#issuecomment-1011241373, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARD7GOJKN4TASVFJ3P53ZHDUVWVO3ANCNFSM5LZD3XIA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you commented.Message ID: @.***>

LukasGrebe commented 2 years ago

Excellent! Thank you so much for your Contribution!

I think we can skip

Add automatic migration script so above is not breaking change (not sure if this is possible or not) as it's only been a few days…

tim-devel commented 2 years ago

Thanks @LukasGrebe but this wasn't quite ready to be merged yet. I put WIP in the title as it was still a work in progress.

I have rolled back the version number as this pull released a new version without docs

LukasGrebe commented 2 years ago

My bad & sorry for the confusion!