LukasJoswiak / etch

A simple, responsive writing theme for Hugo.
https://lukasjoswiak.github.io/etch/
MIT License
295 stars 166 forks source link

Adding new features #29

Closed doliG closed 2 years ago

doliG commented 2 years ago

Hello,

I'm using your theme for one of my blogs. I really like the simplicity of it, but sometimes I wish it to have more features.

Here's the features I'm considering adding:

Are you open to PR or should I fork your repo ?

Thanks

LukasJoswiak commented 2 years ago

Hi, thanks for the ideas.

Date: Use locale to format date Date: User can provide custom date format in blog settings

These sound like good ideas, accessibility and i18n does not have a lot of support in this theme currently.

Taxonomies: Display tags and categories in a post

I discussed this a little in https://github.com/LukasJoswiak/etch/issues/16#issuecomment-816397045. I understand the value of showing all tags/categories automatically for each post. But at the same time, this theme is purposely designed to be simple and if supporting many different tags and categories is your goal it might not be the correct theme. Anyway, I'm open to a PR on this, but no guarantees.

Misc: Display custom title for posts (i.e paintings, recipes, talks...)

I tend to think adding options for things like this causes a trend towards having options for everything, which causes clutter. In my opinion, if someone wants to make this kind of change they should fork the repo and make the change in their fork.

doliG commented 2 years ago

I'll tackle taxonomies later (it's not that important).

Regarding the custom title for the posts, I disagree because post is an english word, and have not its place on a translated website.

We can use hugo i18n to tackle both date format and custom post page title. We could have one en-US.yaml file in the theme and to provide a way for the user can just add its own translation at the root of its project (/i18n) 🤔

What do you think ?

LukasJoswiak commented 2 years ago

Good point, I wasn’t considering the internationalization aspect of the title. That sounds like a good plan to me, would be great to have i18n support!

doliG commented 2 years ago

Hey @LukasJoswiak , I've created for you a PR. Please let me now your thoughts :)