search

LukasKalbertodt / libtest-mimic

A small test framework to write your own test harness that looks and behaves like the built-in test harness used by `rustc --test`
https://docs.rs/libtest-mimic
Apache License 2.0
95 stars 26 forks source link

Multiple threads with `--test-threads` #2

Closed LukasKalbertodt closed 4 years ago

LukasKalbertodt commented 5 years ago

Currently, the argument --test-threads is ignored. This shouldn't be the case.

Nadrieril commented 4 years ago

@LukasKalbertodt Thanks for this library, this is exactly what I needed!

I'm trying to implement multithreading because that would make a huge difference for my use-case. However that would entail a breaking change in the signature of run_tests because we would need D and the closure to be 'static + Send + Sync. Is that ok or would you prefer I write run_tests_threaded with the new signature and keep both functions ?

LukasKalbertodt commented 4 years ago

@Nadrieril Awesome!

No, go ahead and change the signature. The signature without those bounds was a mistake (a lack of foresight) on my side. I can simply release as a new major version.