LukasLen / Privacy-Extension-For-WhatsApp-Web

Hides your WhatsApp messages until you hover over them.
https://pfwa.lukaslen.com
MIT License
118 stars 44 forks source link

On screen of whatsapp it unblurs everithing and isn't bluring the profile pictures #33

Closed Micael-Machado closed 1 year ago

Micael-Machado commented 1 year ago

When the cursor isn't in the site but it's in the browser most part is blured but when the cursor passes to the whatsapp screen it shows everything, and it's not bluring the profile pictures.

UsmanAhmadSaeed commented 1 year ago

@Micael-Machado can you verify that you haven't turned on this option (image below)? This might be the reason everything is unblurred when you hover on WhatsApp Web anywhere. As for the blurring of profile pictures, make sure you've turned on the blur profile picture option in extension settings. That maybe the reason for no blurring of profile pictures. If not, please do let me know because I've been experiencing the same issue, where profile pictures are not being blurred, and if you have the option on and are experiencing the same, it may be due to some new upgrade by WhatsApp. Your confirmation will help @LukasLen verify if that is a persistent issue, as he'll have 2 instances where it is occurring, me and you, or otherwise it might just be me. Either case, win-win. image

pragus99 commented 1 year ago

@UsmanAhmadSaeed That happen to me. Blurring profile picture not working as intended. Whatsapp Web change class name for profile/group pic. Someone needs to make PR for profilePic.css

UsmanAhmadSaeed commented 1 year ago

@pragus99 Yeah I think that's the case. I've tried to update the class but haven't succeeded so far. I'm not sure how to find the correct class. Do you know how can I do that? I tried inspecting and tried some different classes used for the divs above img element of profile picture, as well as classes of img element and where there's no profile picture, classes from there, but none seem to work so far. It just blurs the entire side pane instead.

Micael-Machado commented 1 year ago

Good morning.

I'm using it with the settings below and the occurrence persists:

[image: image.png]

Best regards, Micael Neto.

Em sáb., 25 de mar. de 2023 às 22:09, Usman Ahmad Saeed < @.***> escreveu:

@Micael-Machado https://github.com/Micael-Machado can you verify that you haven't turned on this option (image below)? This might be the reason everything is unblurred when you hover on WhatsApp Web anywhere. As for the blurring of profile pictures, make sure you've turned on the blur profile picture option in extension settings. That maybe the reason for no blurring of profile pictures. If not, please do let me know because I've been experiencing the same issue, where profile pictures are not being blurred, and if you have the option on and are experiencing the same, it may be due to some new upgrade by WhatsApp. Your confirmation will help @LukasLen https://github.com/LukasLen verify if that is a persistent issue, as he'll have 2 instances where it is occurring, me and you, or otherwise it might just be me. Either case, win-win. [image: image] https://user-images.githubusercontent.com/20966983/227749650-f2be183c-533f-4968-a26a-d25647413966.png

— Reply to this email directly, view it on GitHub https://github.com/LukasLen/Privacy-Extension-For-WhatsApp-Web/issues/33#issuecomment-1483963091, or unsubscribe https://github.com/notifications/unsubscribe-auth/AYVYIH2HZNJ2WB3K3CJHSVLW56JMVANCNFSM6AAAAAAWA7EML4 . You are receiving this because you were mentioned.Message ID: @.*** com>

UsmanAhmadSaeed commented 1 year ago

@Micael-Machado I've made a PR with changes that resolves the issue and adds some missing pieces as well. You'll just have to wait for the project owner (@LukasLen) to merge, verify and update the extension. Meanwhile, I've created an unlisted Firefox version to use myself and you're welcome to use it. PFWA-2.12.1.zip

LukasLen commented 1 year ago

Thanks for bringing this to my attention. I can confirm that the profile pictures do not blur anymore. However, the issue @Micael-Machado describes I could not replicate. Maybe you could post more info on here? Your picture wasn't uploaded to GitHub.

Good morning. I'm using it with the settings below and the occurrence persists: [image: image.png] Best regards, Micael Neto.

LukasLen commented 1 year ago

Fixed with 1ce7ae370633422263ae0ab033b8bc4ccd54c223