search

LukasLen / Privacy-Extension-For-WhatsApp-Web

Hides your WhatsApp messages until you hover over them.
https://pfwa.lukaslen.com
MIT License
118 stars 44 forks source link

fixes for latest whatsapp release #61

Closed aritrakrbasu closed 2 months ago

Tgentil commented 3 months ago

I've tested this PR and found it resolves the cache issue, which is great as it eliminates the need for constant cache clearing and relogging into WhatsApp Web, addressing concerns raised in issues #56, #57, and #60 on the repository. However, there are areas for improvement:

  1. The 'Media Gallery' button isn't blurring.
  2. The 'Group/Usernames' blur functionality seems inactive, but it appears to be linked to the 'Last Preview Media' button.
  3. Adding comments next to new selectors would maintain code consistency and clarify the purpose of each selector.

For instance, in the section where new selectors are added without comments:

src/css/mediaPreview.css

x1vjfegm /* New Selector Description */

Only the new selectors lacks a comments.

Despite these areas for improvement, I plan to continue using this version in Chrome's developer mode due to its effective solution to the caching issue.

aritrakrbasu commented 3 months ago

@Tgentil Thank you for your suggestion, I will update the codebase and will update this PR.

Thank you for the support ❤️

Ahmed-Soli commented 3 months ago

@Tgentil Thank you for your suggestion, I will update the codebase and will update this PR.

Thank you for the support ❤️

Thanks for your efforts. Edit: I tested the edits and it seems the blur is working even not blurring the account image is a nice touch, I liked it, however, the extension toggles buttons are not working and if I clicked on Toggle it will unblur and pressing it again does nothing , I must reload the page to get it to work again.

aritrakrbasu commented 3 months ago

Support for all button actions are updated !

UsmanAhmadSaeed commented 3 months ago

@aritrakrbasu Can I use your base to publish my own unlisted version on firefox for personal use? And could you also share why the original extension had stopped working today? I haven't had a look at the differences/edits in your fix and previous.

aritrakrbasu commented 3 months ago

@UsmanAhmadSaeed you can go ahead and use my branch as it is under MIT license. The extension stopped working because WhatsApp has released a new build and due to that the CSS names has changes on their end as they are using module CSS the class names are generated using hash.

LivreAcessoPro commented 2 months ago

There is a version for Firefox ESR, @Tgentil

Tgentil commented 2 months ago

There is a version for Firefox ESR, @Tgentil

@LivreAcessoPro I haven't tested it on Firefox, but PR #66 made by @aryomuzakki appears robust and could be worth trying out on Firefox ESR. It resolved major issues in Chrome effectively, so it's possible it might work well on Firefox too.

LivreAcessoPro commented 2 months ago

@Tgentil image Version 3.x does not support Firefox ESR.

LukasLen commented 2 months ago

Thanks for contributing! I will move forward with #66.