LukasMarx / angular-dynamic-components

99 stars 61 forks source link

dialog service - append - add return type #2

Closed rtpHarry closed 5 years ago

LukasMarx commented 5 years ago

Thanks for submitting this pull request. I generally don't specify the return type on a function, if the type is obvious (to the compiler & the developer). In this case the function has only one return statement, returning a variable that is an instance of a class. So I would say it is clear enough here.

This is definitely a convinience thing and since this is a tutorial, I'm willing to merge this pull request if the return type of ALL functions would be specified consistently. So either all of them have a return type or none.

rtpHarry commented 5 years ago

:) no worries