LukasScheucher / include-what-you-use

Automatically exported from code.google.com/p/include-what-you-use
Other
0 stars 0 forks source link

run_iwyu_tests.py should fail with a friendlier message if you build in release mode #21

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
I was running Release+Asserts and all tests failed with no output. It took a 
bit of debugging to see that IWYU_PATH wasn't there and that tests require a 
Debug+Asserts build. This patch should help future noobs.

Original issue reported on code.google.com by tonyg@chromium.org on 15 Mar 2011 at 12:13

Attachments:

GoogleCodeExporter commented 8 years ago
Thanks for adding this check.  Nothing in the tests requires a debug build 
though, so maybe an even better test would be to have a list of possible 
directories iwyu can live in (I don't know all the output directory names 
llvm/clang uses), and try to find iwyu in each of them, and only fail if it 
can't find iwyu anywhere.  Do you mind trying that approach?

Original comment by csilv...@gmail.com on 15 Mar 2011 at 12:21

GoogleCodeExporter commented 8 years ago
This patch adds a mechanism to search multiple paths. I only added the path I 
needed: Release+Asserts.

Original comment by tonyg@chromium.org on 15 Mar 2011 at 5:47

Attachments:

GoogleCodeExporter commented 8 years ago
Thanks!  I committed a version of your patch (that does the determination of 
iwyu-path at load-time rather than lazily) as r63.  I'm closing the bug, but 
feel free to reopen it if my version of the patch doesn't actually work for you.

Original comment by csilv...@gmail.com on 15 Mar 2011 at 7:21