CMake changed for Clang

[GoogleCodeExporter]

There's work started (possibly ongoing) in Clang to clean up CMake 
configuration. Rev. 158888 changed the setup so IWYU no longer builds.

Attached is a patch to adapt to the new format.

I think this overlaps with the changes submitted for #71.

I've only been able to test this on Windows with MSVC, so if someone can test 
it out on another platform with CMake, I'd be grateful.

Original issue reported on code.google.com by kim.gras...@gmail.com on 1 Jul 2012 at 7:43

Attachments:

• cmake-clang-r158888.patch

[GoogleCodeExporter]

Thanks for patch. I can test CMake build on Mac OS X, but I was going to do so 
with CMake 2.8.9. So I hope I'll test CMake build soon.

Original comment by vsap...@gmail.com on 1 Jul 2012 at 11:50

[GoogleCodeExporter]

Why have you removed
-set(LLVM_LINK_COMPONENTS
 - ipo
-)
? I don't understand why it was there in the first place so maybe you can 
explain? My guess is that at some moment IWYU needed to be linked against 
libLLVMipo, but doesn't need anymore.

Original comment by vsap...@gmail.com on 11 Jul 2012 at 8:49

[GoogleCodeExporter]

Good question -- everything seemed to build fine without it, and it didn't look 
like something IWYU would need, so I assumed it was just a copy/paste 
carry-over.

Original comment by kim.gras...@gmail.com on 11 Jul 2012 at 9:52

[GoogleCodeExporter]

Actually, I think it was the other way around; I checked the diff of another 
clang tool for the cmakeover commit, and it had the ipo link component replaced 
by an include, iirc. The same thing seemed valid for iwyu.

Original comment by kim.gras...@gmail.com on 11 Jul 2012 at 10:04

[GoogleCodeExporter]

This issue was closed by revision r358.

Original comment by vsap...@gmail.com on 11 Jul 2012 at 10:50

• Changed state: Fixed