Closed abeltranandrade closed 1 year ago
the test coverage is failing because I could not get the system.file() function to work even though I followed the previous one I did and also put my test file in the same spot. I had to do a relative file path. For the CMD test to pass, I did the exact relative file path given error messages to be able to get them to find the file and show that the tests are passing.
That is also why the R-CMD checks are passing on github, because they always run the tests and for the check to pass, all the tests have to pass.
For the demo tomorrow we should just keep this in mind to ask Lukas on our meeting and merge it as it is not critical to the functioning of the package, just the test coverage action and I need the function to finish the shiny workflow.
This branch contains get_author_info that uses crossref api calls to get name information of authors and their affiliation. It has 2 basic tests and was passing CMD check locally.
There is also another function that detects if the citation information gathered from parse_pdf_refs from GROBID had first name abbreviation or contained the first name. As this is a function we thought about later and not vital for the MVP flow of our shiny app demo tomorrow, there are no tests done for them and were only fixed for CMD checks, not edge cases.