LukasWallrich / citationProfileR

An R Shiny app to analyse the diversity of academic reference lists
Other
2 stars 0 forks source link

`get_location()` function efficiency #28

Closed lmikhelashvili closed 1 year ago

lmikhelashvili commented 1 year ago

get_location() currently checks if the country_name and country_code columns have any pre-existing values other than NA after the function already got the locations from OSM and countrycode package. This might not be the most efficient way to check. In the future, it would be nice to check if there are any pre-existing values before the function employs OSM and countrycode.

lmikhelashvili commented 1 year ago

This issue is resolved!