search

LukasWallrich / citationProfileR

An R Shiny app to analyse the diversity of academic reference lists
Other
2 stars 0 forks source link

Non-ASCII characters in `sample_data_frame` for `get_location()` #31

Closed lmikhelashvili closed 1 year ago

lmikhelashvili commented 1 year ago

When doing the CMD check I keep getting a warning about non-ASCII characters present in the sample_data_frame. The screenshot is attached below. I reviewed the chapter 8.1.2 Documenting datasets R here and they seem to say that this warning is not a big deal. It says this warning is suppressed by R CMD check --as-cran. I could not find a way to resolve this, so I think this would be an enhancement in the future.

Screen Shot 2023-05-03 at 1 23 59 PM
lmikhelashvili commented 1 year ago

Ultimately, I think a way to resolve this issue is by replacing sample_data_frame to a data object that does not contain any ASCII characters. However, this issue might arise if the affiliation name has non-ASCII characters in the future.

lmikhelashvili commented 1 year ago

Could not approve a pull request #35 because of this issue.