search

LukasWallrich / citationProfileR

An R Shiny app to analyse the diversity of academic reference lists
Other
2 stars 0 forks source link

final feature of guess_gender cache implementation to be resolved (name-country code combo) #33

Open rithika-d opened 1 year ago

rithika-d commented 1 year ago

Right now, there is no way to add two variables in the env_cache() function so the result will always be based on the name rather than the country code though I'm working on resolving that.

LukasWallrich commented 1 year ago

Is this really resolved? The current function seems to pass both name and countrycode to the rlang env function - while I think they need to be combined (e.g. paste0(name, countrycode, sep = "_"))

LukasWallrich commented 1 year ago

Also, need to fix the cache = TRUE implementation - the idea here needs to be to try to use the cache and otherwise request from the API - not to fail (I can do that).

rithika-d commented 1 year ago

Hi Lukas! I now made it so that a unique name-country code combination was saved to the cache so I don't believe that is still an issue. However, I think that when a name-country combination isn't in the cache there is a problem with the env_get() function itself because that gives an error when that respective pairing isn't there so that's why it breaks in the shiny because the "name, country" is not how that appears in the citations so I think there needs to be some transition between the guess_gender and shiny code