LukasWallrich / metaUI

Create shiny apps that allow explore of meta-analysis results
https://lukaswallrich.github.io/metaUI/
GNU General Public License v3.0
5 stars 0 forks source link

Add copyright notices #4

Closed LukasWallrich closed 1 year ago

LukasWallrich commented 1 year ago
LukasWallrich commented 1 year ago
LukasWallrich commented 1 year ago

@LukasRoeseler should we specifically cite your other apps as code sources? Or just have you as an author and copyright holder?

LukasRoeseler commented 1 year ago

@LukasWallrich I would feel more comfortable with citing the Apps that we took the code from (see below for the full references). Also, I here is code from the OpAQ-App that automatically list all loaded R-packages. It's only the names but maybe that is useful for this one, too. We can discuss this, if you want.

packages_list <- HTML(paste("

- ", names(sessionInfo()[["otherPkgs"]]), sep = ""))

References:

LukasWallrich commented 1 year ago

Thanks - we would not cite other packages within the package itself, but could add that to the Shiny about page? Your code there would not work here because we do not load the packages here (to avoid namespace conflicts, I am referring to each function with the pkg::fun() syntax) - but the following works req_packages <- pacman::p_depends("metaUI", local = TRUE) %>% purrr::pluck("Imports")

I am happy to add these citations to the README, and thus to the package webpage. However, do you think all of the authors needs to be listed as code copyright holders in DESCRIPTION (especially for the tiny OpAQ snippet we used)? Or was the code itself just your work?

LukasRoeseler commented 1 year ago

I see, yes all of the code that we took was written by me. None of the other authors need to be listed as code copyright holders.