search

LukasZahradnik / PyNeuraLogic

PyNeuraLogic lets you use Python to create Differentiable Logic Programs
https://pyneuralogic.readthedocs.io/
MIT License
269 stars 17 forks source link

fix order of parameters and mask for Data.from_pyg #35

Closed joaquincabezas closed 1 year ago

joaquincabezas commented 1 year ago

Currently the function for converting Pytorch Geometric datasets into Data objects is broken because of the ordering of parameters. This PR fixes it.

codecov-commenter commented 1 year ago

Codecov Report

Merging #35 (8f1d49d) into master (88cb6a6) will decrease coverage by 0.05%. The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master      #35      +/-   ##
==========================================
- Coverage   76.34%   76.29%   -0.06%     
==========================================
  Files          88       88              
  Lines        4241     4244       +3     
==========================================
  Hits         3238     3238              
- Misses       1003     1006       +3
Impacted Files Coverage Δ
neuralogic/dataset/tensor.py 82.00% <0.00%> (-2.54%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 88cb6a6...8f1d49d. Read the comment docs.

LukasZahradnik commented 1 year ago

Hi, thanks for your contribution. Your fixes will be released in the next patch version.

joaquincabezas commented 1 year ago

Thank you! I hope to keep contributing for a while :)