search

LukasZahradnik / deep-db-learning

A modular message-passing scheme reflecting the relational model for end-to-end deep learning from databases
https://lukaszahradnik.github.io/deep-db-learning/
6 stars 2 forks source link

Wasteful use of `with engine.connect() as connection` #7

Closed neumannjan closed 1 year ago

neumannjan commented 1 year ago

https://github.com/LukasZahradnik/deep-db-learning/blob/a52d83dcb086377e46cc9346466c7ad3a8f04b3f/db_transformer/ndata/dataset.py#L80

I would argue that only one persistent connection is needed during the existence of the Dataset, instead of such repeated connecting.

This is worth discussing though, I guess.