search

LukasZahradnik / deep-db-learning

A modular message-passing scheme reflecting the relational model for end-to-end deep learning from databases
https://lukaszahradnik.github.io/deep-db-learning/
6 stars 2 forks source link

Dataset get() ignores local copy and uses remote #9

Closed neumannjan closed 1 year ago

neumannjan commented 1 year ago

https://github.com/LukasZahradnik/deep-db-learning/blob/a52d83dcb086377e46cc9346466c7ad3a8f04b3f/db_transformer/ndata/dataset.py#L59-L60

https://github.com/LukasZahradnik/deep-db-learning/blob/a52d83dcb086377e46cc9346466c7ad3a8f04b3f/db_transformer/ndata/dataset.py#L78-L79

Both process() and get() are accessing the remote database rather than the local, despite the local having been downloaded.

However, when I make it use the local, then get() doesn't work anymore :D . I think one of the reasons why is the issue #10 .

Also, the schema autodetection should arguably also run on the local copy, not on the remote.