Lukasa / language-restructuredtext

A ReStructuredText syntax package for Atom
MIT License
27 stars 15 forks source link

After updating to 0.16, the syntax highlighting color of sections disappear. #42

Closed amoshyc closed 8 years ago

amoshyc commented 8 years ago

The color of the section part used to be green, but changing to white after updating to 0.16. Is it the intended result?

See the window on the left. screenshot from 2016-06-11 00-19-36

Window on the right is how markdown code was rendered and it is what I'm expecting.

Another screenshot screenshot from 2016-06-11 00-29-09

I'm using

language-restructuredtext 0.16.0
Atom 0.18
Fedora 23
Lukasa commented 8 years ago

Do you have screenshots of the prior rendering?

@Alhadis, you may find this interesting.

Alhadis commented 8 years ago

@amoshyc Can you tell us what themes you're using, and what the syntax looked like beforehand?

I'm also not sure what the Markdown file has to do with this... it's a completely different language.

amoshyc commented 8 years ago

I'm sorry I don't have screenshots of the prior rendering. The screenshot of the markdown file in my previous comment demonstrates what I'm expecting and it is the syntax color rst used to be. (Color of the headers is green)

I'm using monokai with ui theme atom dark.

Alhadis commented 8 years ago

Okay, the "green" parts you're referring to are actually commented-out sections. That's the expected result.

When you say "headers", what are you referring to? The ================= parts?

amoshyc commented 8 years ago

Yes. Sorry for my English. I mean heading actually. The ================== is green.

================
Heading
================

This is what rst was rendered at version 0.15 screenshot from 2016-06-12 00-30-01

Alhadis commented 8 years ago

Ah, this is probably why you were seeing it. Monokai applies Markdown-specific styling, and the theme was previously pretending to be Markdown before v0.16. This was changed for compatibility reasons.

If you feel strongly about borders not having highlighting, you might want to file an issue on the Monokai repository.

amoshyc commented 8 years ago

OK. Thank you

Lukasa commented 8 years ago

Thanks folks!