search

Lukasa / language-restructuredtext

A ReStructuredText syntax package for Atom
MIT License
27 stars 15 forks source link

Allow colon and plus sign in link definition #51

Closed jessetan closed 7 years ago

jessetan commented 7 years ago

Changed regex to allow colon and plus sign. Changed matching of link target name to non-greedy for proper matching of colon. Note that I have kept the existing \\d\\w, although it seems superflous since \w already matches [A-Za-z0-9_].

Fixes #50

Alhadis commented 7 years ago

To be honest, there're probably many more inaccuracies littered through the grammar. When I cleaned it up, I had only a trivial understanding of reStructuredText, and avoided changing whatever I wasn't sure about.

So by all means, go nuts with cutting out the crap. :)

jessetan commented 7 years ago

I'll keep that in mind for the next PR, don't want to refactor just for the sake of it. Perhaps good to put this in the README?

Alhadis commented 7 years ago

Nah, better off sticking that in HELPME.rst, heh. (I jest)

ANYWAY. There's no need to refactor what I refactored the living shit out of last year, haha. It's really just the character classes that need refinement, I think. Not a massive issue, but it does mean stuff like this will surface sooner or later.