search

Lukasa / requests-ftp

An FTP transport adapter for use with the Python Requests library.
Other
69 stars 25 forks source link

Requests version in requirements.txt is too old, change to >= 2.3.0 #12

Closed migurski closed 8 years ago

migurski commented 9 years ago

Requests 1.0.0+ is listed in requirements.txt, but Requests FTP relies on ConnectTimeout which only appeared as of c2aeaa3, probably Requests version 2.3.0:

  File "/usr/local/lib/python2.7/dist-packages/requests_ftp/__init__.py", line 21, in <module>
    from .ftp import FTPAdapter, monkeypatch_session
  File "/usr/local/lib/python2.7/dist-packages/requests_ftp/ftp.py", line 13, in <module>
    from requests.exceptions import ConnectionError, ConnectTimeout, ReadTimeout
ImportError: cannot import name ConnectTimeout
yarikoptic commented 8 years ago

Since still open I guess this module is not maintained

emanuil-tolev commented 8 years ago

It is looking for a maintainer I think. I'm using it in production and trying to find enough time to get into its guts properly, but have only managed short bursts of activity so far. I'll still try to help if you have a problem.

You can submit a PR for this particular issue easily. In fact I might look at doing that over the weekend as well.

Lukasa commented 8 years ago

That's correct. I am willing to review and merge fixes, but this module is outside my professional remit so I really have no time to actively develop it.

yarikoptic commented 8 years ago

I am away from the keyboard ATM so submitted the PR on the phone to close this one based on original report information.