search

Lukasa / requests-ftp

An FTP transport adapter for use with the Python Requests library.
Other
68 stars 25 forks source link

Move tests/ under requests_ftp module itself + minor facelift to travis.yml #25

Closed yarikoptic closed 8 years ago

yarikoptic commented 8 years ago

Since tests/ is relatively lightweight it is generally advisable to contain them within the package itself, so anyone who has it installed could test it "As installed" to verify correct operation in his environment

yarikoptic commented 8 years ago

yeay -- tests still pass ;) I was worrying that travis doesn't report back here

Lukasa commented 8 years ago

Thanks for doing this work! However, I'm generally disinclined to do this: shipping tests weirdly places us in the situation where the test code, not intended to be product-ready, is now importable by downstream users. This is generally something I don't want to do: I tend to want to ship as few LoC as possible to users for them to achieve their goals.

Sorry!

yarikoptic commented 8 years ago

You are the boss. Just last word - Both arguments (fewer LoC, not product ready tests, when entire module is says to be quick and dirty hack) are a bit dubious to me though. It is like saying to not ship Readme with the package since it might have typos. They go against common practices and complicate as installed testing (eg autopkgtests in debian) for no benefit really. Whoever user does not want to run tests, doesn't have to import them.

On July 10, 2016 4:18:15 AM EDT, Cory Benfield notifications@github.com wrote:

Thanks for doing this work! However, I'm generally disinclined to do this: shipping tests weirdly places us in the situation where the test code, not intended to be product-ready, is now importable by downstream users. This is generally something I don't want to do: I tend to want to ship as few LoC as possible to users for them to achieve their goals.

Sorry!

You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: https://github.com/Lukasa/requests-ftp/pull/25#issuecomment-231576926