search

Lukasa / requests-ftp

An FTP transport adapter for use with the Python Requests library.
Other
69 stars 25 forks source link

expose FTPSession #33

Closed j08lue closed 6 years ago

j08lue commented 6 years ago

I am trying to get into using this library. But if I am not mistaken, two of the examples in the README are wrong: When not monkey-patching, the FTPSession class must be imported either from requests_ftp.ftp.FTPSession or - after this PR is merged - from requests_ftp.

Also, I think the quality declarations are a bit too scary. This implementation might not be perfect, but still useful. And there are already some tests. Some code coverage would help. I can perhaps address this in another PR...

Lukasa commented 6 years ago

Thanks for this! While you’re welcome to improve this module I should strongly note that I do not recommend using it, and that it would be better to use a proper FTP library directly. For this reason I don’t want to remove the quality warnings. 😉

j08lue commented 6 years ago

I see. I followed your advice.

Maybe you should consider removing the package from PyPA? As a proof-of-concept, it might have some value here on GitHub, but if the concept actually is flawed and this is not a good example for how to do things right with requests, maybe you should even remove it from here? Considering that you are a requests developer and actually know how things should be done... 😄

Lukasa commented 6 years ago

Removing it is extreme: it has interesting academic value and it’s a good reference, it’s just not something people should build production code on.

j08lue commented 6 years ago

Sure, sorry, the suggestion to remove it even from GitHub was perhaps out of proportion. 😄