search

Lukasa / requests-ftp

An FTP transport adapter for use with the Python Requests library.
Other
69 stars 25 forks source link

add support for SIZE (only manually tested) #9

Closed emanuil-tolev closed 10 years ago

emanuil-tolev commented 10 years ago

I read the note on unit tests but:

  1. need a mock FTP server, not that trivial?
  2. there's no current testing framework in place (e.g. which one should be used, the Python built-in one will probably suffice but pytest is more readable / less boilerplate .. etc.)

Anyhow, would completely understand if you reject the pull req :). It was written quite quickly. Seems to be a pattern with programmatic FTP usage. I basically just wanted to point the code out - if I have more time one of these weeks I ought to make a more serious attempt at a contribution..

Lukasa commented 10 years ago

This looks great, thanks! :cake:

Yeah, the unit test comments were made a long time ago when I expected I'd be doing more work on this library. Given that people seem to be picking it up it might be worth me coming back and arranging some form of UT.