Lukasz-Semik / cash-organizer

Small app helping organize expenses. Technology stack: ReactJS, Redux, Webpack, Firebase, SCSS
1 stars 0 forks source link

Config for port #1

Open michaelKurowski opened 7 years ago

michaelKurowski commented 7 years ago

https://github.com/Lukasz-Semik/cash-organizer/blob/80172dbca7300976928c065acc55a32c57a762f0/server/server.js#L6

Wouldn't it be better to do like: portFromConfigFile || environmentalVariable || 3000

Some ppl might prefer setting config file instead of environmental OS variables.

Lukasz-Semik commented 6 years ago

I need to learn more

michaelKurowski commented 6 years ago

Just create a JSON file somewhere, which will work as config, and import it.