search

Lukasz-Semik / cash-organizer

Small app helping organize expenses. Technology stack: ReactJS, Redux, Webpack, Firebase, SCSS
1 stars 0 forks source link

Modularize the dataActions startTakeDbData #8

Open michaelKurowski opened 7 years ago

michaelKurowski commented 7 years ago

https://github.com/Lukasz-Semik/cash-organizer/blob/80172dbca7300976928c065acc55a32c57a762f0/app/src/actions/dataActions.js#L11-L63

This chunk of code is way too long. Split it into smaller functions. Also startTakeDbDate is a little bit odd name.

Lukasz-Semik commented 6 years ago

This file has to be split to the smaller ones. Agreed

michaelKurowski commented 6 years ago

Not only split into files, but that function is too long, and too nested.