Luke-Fanguna / FoodForLesser

0 stars 0 forks source link

Code Review Comments Ian McCurry #26

Open ianmccurry11 opened 10 months ago

ianmccurry11 commented 10 months ago
  1. Only one working branch, you should have more for development
  2. Long routes such as "/crowdsourcing/{user_id}/upload/{store_id}/{item_id}/{grocery_price}"
  3. Most recent commit. message for crowdsourcing.py is "should work". Not enough info for a commit message and too vague on what changed
  4. In api folder you have left files from potions lab like barrels.py
  5. using "INSERT INTO grocery_list (user_id) SELECT :user_id" instead of "INSERT INTO grocery_list (user_id) VALUES :user_id
  6. lots of queries results get up into variables named "result", more meaningful names would be better
  7. store apis are under route "/list" instead of a "/store" route
  8. delete_item has a comment saying it deletes an item by name when it takes in no name
  9. No way of really seeing what items I can add to a list
  10. crowdsourcing/{posting_id}/update/{grocery_price} is called get_bottle_plan()
  11. /lists/stores/{list_id}/best doesnt work for a list_id that contians more than one item
  12. list/{posting_id}/items/ deletes all items unlike described in api and description
  13. "itemPrice = 999999" in stores/best/ is a bad way of excluding a store from the search