issues
search
Luke-Fanguna
/
FoodForLesser
0
stars
0
forks
source link
Schema/API Design Comments Ian McCurry
#34
Open
ianmccurry11
opened
1 year ago
ianmccurry11
commented
1 year ago
ERD says one and only one user per list but you can create many lists per user
schema order is not correct with foreign key ties
APIs have almost all data coming in from url when not necessary like POST for crowdsourcing
/lists/stores/ is a POST call instead of a GET call
/lists/stores/{list_id}/best should be GET
crowdsourcing/{posting_id}/delete is bad naming convention and should just be crowdsourcing/{posting_id}
APISpec.md isnt correctly formatted
better names for the "id"s in all the tables to help specify what idea youre talking about is a good idea (i.e. item_id, user_id)
"Create a new grocery list" API says it takes no input. But it requires a user_id
inventory should just be an int instead of text, because inventory_level doesnt get changed and is too vague
more descriptive names for table variables like "name" (i.e. store_name, user_name)
no API to create users