Luke100000 / ImmersiveAircraft

Various vanilla-friendly aircraft to explore the world at a higher pace.
https://modrinth.com/mod/immersive-aircraft
GNU General Public License v3.0
40 stars 26 forks source link

QUESTION: Roll limits #142

Closed GrahamJenkins closed 4 months ago

GrahamJenkins commented 4 months ago

Hello, I'm loving this mod, great work on it. One area that could be (IMHO) improved is plane roll limitations. I couldn't find these values when extracting the jar (many others though) and was hoping to find a way to allow aircraft to either rotate a full 90 degrees, or ideally just remove the roll constraint.

I'm not afraid to adjust a file and recompile the mod, I was just hoping for a pointer towards where this may be.

OR if you're feeling ambitious and generous and wanted to provide this as an easy configuration value, that would be cool as well.

Thanks!

GrahamJenkins commented 4 months ago

As an addon, someone recently suggested that players should be able to fall out of their planes. If I were to implement this I would add a simple counter, and if the plane was oriented between let's say 150 and 210 degrees (aka mostly upside down) for more than 3-5 seconds they're forcibly ejected. Just a suggestion, for bonus points.

Luke100000 commented 4 months ago

For rolling you would need two additional keys and Immersive Aircraft simply does not use a 3 axis flight mechanics at all, so rolling is technically not possible. If you want to tinker around you would need to replace the physics with a proper, 3 dimensional one.

GrahamJenkins commented 4 months ago

@Luke100000 Ah, now that I think of it, I understand. I was assuming that since blimps have no roll, but gyros, quads and biplanes have different amount of "roll" while rotating, there was some form of roll that could be configured. But now that you say it, I realize that what's happening is the airplane's visual "roll" is actually probably just a function of how tightly the aircraft is turning, NOT actual roll.

So yeah, 3 axis mechanics would be cool, but that's way more work than simply adjusting a maxRoll variable as I was assuming. Since we're on the topic, is 3 axis mechanics something you have/would consider at some point? The Do a Barrel Roll mod comes to mind, not that I'm volunteering to attempt porting anything ;-)

Luke100000 commented 4 months ago

Yes, you can configure the visual roll computed directly from the X controller input.

I thought about 3rd axis, but a) I think in the context of Minecraft, an easier mechanic is better and b) iirc there are other mods already doing that.

What I added in a separate branch is a barrel roll. Has no actual impact, just a funny roll because realistically, thats what most people will use rolling for anyways. Not for physically accurate flight XD

GrahamJenkins commented 4 months ago

Sounds good @Luke100000 , I think your stance is the proper one. Feel free to ping me if that gets merged/released, I'll include it in my latest pack and let people figure that part out :D