search

Luke100000 / ImmersiveMelodies

Play custom melodies on various instruments and annoy your friends!
Other
4 stars 4 forks source link

license metadata mismatch #10

Closed benaryorg closed 10 months ago

benaryorg commented 10 months ago

Describe the bug The license reported by the mod does not match the actual license in use (as far as I can see). Currently the license is reported as GNU.

Latest.log -

To Reproduce -

Expected behavior

I would expect the mod to adhere to the SPDX standards in the following places, considering that "GNU" is neither correct nor sufficient to determine the license (more info in the additional context section):

https://github.com/Luke100000/ImmersiveMelodies/blob/db8bace39f6fbc443ae7311988f97fd81e84c780/fabric/src/main/resources/fabric.mod.json#L15

https://github.com/Luke100000/ImmersiveMelodies/blob/db8bace39f6fbc443ae7311988f97fd81e84c780/forge/src/main/resources/META-INF/mods.toml#L4

Screenshots screenshot of the forge mod list listing the mod as having the license "GPL"

Additional context

The LICENSE file at time of writing seems¹ to be GPL-3.0-only (referred to using the SPDX license identifier).

SPDX license identifiers are recommended by fabric for its metadata for instance:

To aid automated tools, it is recommended to use SPDX License Identifiers for open-source licenses.

¹: the author(s) should verify that GPL 3.0 only is the correct license, as opposed to GPL 3.0 or-later for instance

Luke100000 commented 10 months ago

That copy pasta is present in several other mods, thanks for reporting.