search

Luke100000 / ImmersiveMelodies

Play custom melodies on various instruments and annoy your friends!
Other
8 stars 3 forks source link

Add an option to allow uploading custom music tracks but not converting abc to midi #72

Closed Blayung closed 2 weeks ago

Blayung commented 1 month ago

I'm unsure whether the conversion happens on the client on the server, if it's on the client then you can simply close this issue.

Luke100000 commented 1 month ago

Parsing ABC files is extremely complicated, the conversion to midi is therefore necessary.

Blayung commented 1 month ago

I meant, if a player tries to upload an abc file, the server will just reject it.

Luke100000 commented 3 weeks ago

Then I would need said ABC to debug :)

Blayung commented 3 weeks ago

Huh?

Luke100000 commented 3 weeks ago

The file. Upload it here. How should I debug a crashing file without the file? ^^

Blayung commented 3 weeks ago

Okay, sorry if I didn't communicate it clearly, but I meant to add an option on the server to reject abc files. I'm not having problems with the server rejecting files, I want it to do it.

Luke100000 commented 3 weeks ago

In what scenario does this make sense?

Blayung commented 3 weeks ago

When I don't want the server to send queries to your api. Unless,

I'm unsure whether the conversion happens on the client on the server, if it's on the client then you can simply close this issue.

Luke100000 commented 2 weeks ago

Ah I see, yes the conversion is client sided.