Luke100000 / ImmersivePaintings

Minecraft mod. Use your own paintings! Drag and drop! In Multiplayer!
GNU General Public License v3.0
11 stars 16 forks source link

[1.16.5] - Crash When Using An Image on the Painting #5

Closed PhweeDev closed 2 years ago

PhweeDev commented 2 years ago

---- Minecraft Crash Report ---- // Daisy, daisy...

Time: 7/20/22 12:24 PM Description: mouseClicked event handler

java.nio.file.InvalidPathException: Illegal char <:> at index 5: https://cdn.discordapp.com/attachments/952003799671779338/999360331774173274/Screenshot_2022-07-20_093852.png at sun.nio.fs.WindowsPathParser.normalize(WindowsPathParser.java:182) ~[?:1.8.0_312] {} at sun.nio.fs.WindowsPathParser.parse(WindowsPathParser.java:153) ~[?:1.8.0_312] {} at sun.nio.fs.WindowsPathParser.parse(WindowsPathParser.java:77) ~[?:1.8.0_312] {} at sun.nio.fs.WindowsPath.parse(WindowsPath.java:94) ~[?:1.8.0_312] {} at sun.nio.fs.WindowsFileSystem.getPath(WindowsFileSystem.java:255) ~[?:1.8.0_312] {} at java.nio.file.Paths.get(Paths.java:84) ~[?:1.8.0_312] {} at immersive_paintings.client.gui.ImmersivePaintingScreen.loadImage(ImmersivePaintingScreen.java:652) ~[immersive_paintings:?] {re:classloading} at immersive_paintings.client.gui.ImmersivePaintingScreen.loadImage(ImmersivePaintingScreen.java:636) ~[immersive_paintings:?] {re:classloading} at immersive_paintings.client.gui.ImmersivePaintingScreen.lambda$rebuild$8(ImmersivePaintingScreen.java:216) ~[immersive_paintings:?] {re:classloading} at net.minecraft.client.gui.widget.button.Button.func_230930b(SourceFile:33) ~[?:?] {re:classloading} at net.minecraft.client.gui.widget.button.AbstractButton.func_230982a(SourceFile:16) ~[?:?] {re:classloading} at net.minecraft.client.gui.widget.Widget.func_231044a(Widget.java:136) ~[?:?] {re:classloading,pl:runtimedistcleaner:A} at net.minecraft.client.gui.INestedGuiEventHandler.func_231044a(SourceFile:27) ~[?:?] {re:classloading} at net.minecraft.client.MouseHelper.func_198033_b(MouseHelper.java:87) ~[?:?] {re:classloading,pl:runtimedistcleaner:A} at net.minecraft.client.gui.screen.Screen.func_231153a(Screen.java:427) ~[?:?] {re:classloading,pl:runtimedistcleaner:A} at net.minecraft.client.MouseHelper.func_198023_a(MouseHelper.java:85) ~[?:?] {re:classloading,pl:runtimedistcleaner:A} at net.minecraft.client.MouseHelper.func_228030c(MouseHelper.java:181) ~[?:?] {re:classloading,pl:runtimedistcleaner:A} at net.minecraft.util.concurrent.ThreadTaskExecutor.execute(SourceFile:94) ~[?:?] {re:classloading,pl:accesstransformer:B} at net.minecraft.client.MouseHelper.func_228028b(MouseHelper.java:180) ~[?:?] {re:classloading,pl:runtimedistcleaner:A} at org.lwjgl.glfw.GLFWMouseButtonCallbackI.callback(GLFWMouseButtonCallbackI.java:36) ~[lwjgl-glfw-3.2.2.jar:build 10] {} at org.lwjgl.system.JNI.invokeV(Native Method) ~[lwjgl-3.2.2.jar:build 10] {} at org.lwjgl.glfw.GLFW.glfwPollEvents(GLFW.java:3101) ~[lwjgl-glfw-3.2.2.jar:build 10] {} at com.mojang.blaze3d.systems.RenderSystem.flipFrame(SourceFile:102) ~[?:?] {re:classloading} at net.minecraft.client.MainWindow.func_227802e(MainWindow.java:306) ~[?:?] {re:classloading,pl:runtimedistcleaner:A} at net.minecraft.client.Minecraft.func_195542_b(Minecraft.java:997) ~[?:?] {re:classloading,pl:accesstransformer:B,pl:runtimedistcleaner:A} at net.minecraft.client.Minecraft.func_99999_d(Minecraft.java:607) ~[?:?] {re:classloading,pl:accesstransformer:B,pl:runtimedistcleaner:A} at net.minecraft.client.main.Main.main(Main.java:184) ~[1.16.5.jar:?] {re:classloading,pl:runtimedistcleaner:A} at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_312] {} at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:1.8.0_312] {} at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_312] {} at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_312] {} at net.minecraftforge.fml.loading.FMLClientLaunchProvider.lambda$launchService$0(FMLClientLaunchProvider.java:51) ~[forge-1.16.5-36.2.34.jar:36.2] {} at cpw.mods.modlauncher.LaunchServiceHandlerDecorator.launch(LaunchServiceHandlerDecorator.java:37) [modlauncher-8.1.3.jar:?] {} at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:54) [modlauncher-8.1.3.jar:?] {} at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:72) [modlauncher-8.1.3.jar:?] {} at cpw.mods.modlauncher.Launcher.run(Launcher.java:82) [modlauncher-8.1.3.jar:?] {} at cpw.mods.modlauncher.Launcher.main(Launcher.java:66) [modlauncher-8.1.3.jar:?] {}

A detailed walkthrough of the error, its code path and all known details is as follows:

-- Head -- Thread: Render thread Stacktrace: at sun.nio.fs.WindowsPathParser.normalize(WindowsPathParser.java:182) ~[?:1.8.0_312] {} at sun.nio.fs.WindowsPathParser.parse(WindowsPathParser.java:153) ~[?:1.8.0_312] {} at sun.nio.fs.WindowsPathParser.parse(WindowsPathParser.java:77) ~[?:1.8.0_312] {} at sun.nio.fs.WindowsPath.parse(WindowsPath.java:94) ~[?:1.8.0_312] {} at sun.nio.fs.WindowsFileSystem.getPath(WindowsFileSystem.java:255) ~[?:1.8.0_312] {} at java.nio.file.Paths.get(Paths.java:84) ~[?:1.8.0_312] {} at immersive_paintings.client.gui.ImmersivePaintingScreen.loadImage(ImmersivePaintingScreen.java:652) ~[immersive_paintings:?] {re:classloading} at immersive_paintings.client.gui.ImmersivePaintingScreen.loadImage(ImmersivePaintingScreen.java:636) ~[immersive_paintings:?] {re:classloading} at immersive_paintings.client.gui.ImmersivePaintingScreen.lambda$rebuild$8(ImmersivePaintingScreen.java:216) ~[immersive_paintings:?] {re:classloading} at net.minecraft.client.gui.widget.button.Button.func_230930b(SourceFile:33) ~[?:?] {re:classloading} at net.minecraft.client.gui.widget.button.AbstractButton.func_230982a(SourceFile:16) ~[?:?] {re:classloading} at net.minecraft.client.gui.widget.Widget.func_231044a(Widget.java:136) ~[?:?] {re:classloading,pl:runtimedistcleaner:A} at net.minecraft.client.gui.INestedGuiEventHandler.func_231044a(SourceFile:27) ~[?:?] {re:classloading} at net.minecraft.client.MouseHelper.func_198033_b(MouseHelper.java:87) ~[?:?] {re:classloading,pl:runtimedistcleaner:A} -- Affected screen -- Details: Screen name: immersive_paintings.client.gui.ImmersivePaintingScreen Stacktrace: at net.minecraft.client.gui.screen.Screen.func_231153a(Screen.java:427) ~[?:?] {re:classloading,pl:runtimedistcleaner:A} at net.minecraft.client.MouseHelper.func_198023_a(MouseHelper.java:85) ~[?:?] {re:classloading,pl:runtimedistcleaner:A} at net.minecraft.client.MouseHelper.func_228030c(MouseHelper.java:181) ~[?:?] {re:classloading,pl:runtimedistcleaner:A} at net.minecraft.util.concurrent.ThreadTaskExecutor.execute(SourceFile:94) ~[?:?] {re:classloading,pl:accesstransformer:B} at net.minecraft.client.MouseHelper.func_228028b(MouseHelper.java:180) ~[?:?] {re:classloading,pl:runtimedistcleaner:A} at org.lwjgl.glfw.GLFWMouseButtonCallbackI.callback(GLFWMouseButtonCallbackI.java:36) ~[lwjgl-glfw-3.2.2.jar:build 10] {} at org.lwjgl.system.JNI.invokeV(Native Method) ~[lwjgl-3.2.2.jar:build 10] {} at org.lwjgl.glfw.GLFW.glfwPollEvents(GLFW.java:3101) ~[lwjgl-glfw-3.2.2.jar:build 10] {} at com.mojang.blaze3d.systems.RenderSystem.flipFrame(SourceFile:102) ~[?:?] {re:classloading}

-- Affected level -- Details: All players: 1 total; [ClientPlayerEntity['JustPhwee'/198, l='ClientLevel', x=119.22, y=67.72, z=56.90]] Chunk stats: Client Chunk Cache: 289, 169 Level dimension: minecraft:overworld Level spawn location: World: (112,67,48), Chunk: (at 0,4,0 in 7,3; contains blocks 112,0,48 to 127,255,63), Region: (0,0; contains chunks 0,0 to 31,31, blocks 0,0,0 to 511,255,511) Level time: 1368 game time, 1368 day time Server brand: forge Server type: Integrated singleplayer server Stacktrace: at net.minecraft.client.world.ClientWorld.func_72914_a(ClientWorld.java:447) ~[?:?] {re:classloading,pl:accesstransformer:B,pl:runtimedistcleaner:A,re:mixin,pl:accesstransformer:B,pl:runtimedistcleaner:A} at net.minecraft.client.Minecraft.func_71396_d(Minecraft.java:2031) ~[?:?] {re:classloading,pl:accesstransformer:B,pl:runtimedistcleaner:A} at net.minecraft.client.Minecraft.func_99999_d(Minecraft.java:623) ~[?:?] {re:classloading,pl:accesstransformer:B,pl:runtimedistcleaner:A} at net.minecraft.client.main.Main.main(Main.java:184) ~[1.16.5.jar:?] {re:classloading,pl:runtimedistcleaner:A} at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_312] {} at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:1.8.0_312] {} at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_312] {} at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_312] {} at net.minecraftforge.fml.loading.FMLClientLaunchProvider.lambda$launchService$0(FMLClientLaunchProvider.java:51) ~[forge-1.16.5-36.2.34.jar:36.2] {} at cpw.mods.modlauncher.LaunchServiceHandlerDecorator.launch(LaunchServiceHandlerDecorator.java:37) [modlauncher-8.1.3.jar:?] {} at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:54) [modlauncher-8.1.3.jar:?] {} at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:72) [modlauncher-8.1.3.jar:?] {} at cpw.mods.modlauncher.Launcher.run(Launcher.java:82) [modlauncher-8.1.3.jar:?] {} at cpw.mods.modlauncher.Launcher.main(Launcher.java:66) [modlauncher-8.1.3.jar:?] {}

Also. Do you plan on adding .gif or .apng support in the future? If so, that'll be amazing! Since no other mod really has great support for gifs and such like this one does.

PhweeDev commented 2 years ago

*I should also mention this is essentially a copy of #1 but I assume you haven't done this for 1.16.5 yet.

Luke100000 commented 2 years ago

I fixed it, but it seems like I missed some related errors. Thanks. It only happens on Windows, that's why I keep missing that bug ^^

Luke100000 commented 2 years ago

I pushed another versions, can you please test it for me? Should appear in 10 minutes