Luke100000 / ImmersivePaintings

Minecraft mod. Use your own paintings! Drag and drop! In Multiplayer!
GNU General Public License v3.0
11 stars 16 forks source link

Paintings/Graffiti Disappearing when logging out? #74

Open StonedGoat opened 1 month ago

StonedGoat commented 1 month ago

Describe the bug Graffiti seemingly randomly despawns upon logging out/back into the server I'm on. This also affects paintings, it seems. This isn't very clear as to why, as it's only affecting many newly placed paintings now, while previously placed ones have been untouched for some time. They do not break, seemingly, as there is no item left afterwards, though this could be due to chunks unloading.

Latest.log Client: latest.log

Server: latest.log

To Reproduce Place any painting or graffiti in the world. Disconnect from the server at any point after placing it. Possibly affected by reconnect, unable to test currently.

Expected behavior For the painting or graffiti to not be randomly picked out to be despawned.

Screenshots N/A

Additional context Unsure what else to say. My theory was originally that it might be affected by some kind of entity limits, since the graffiti and possibly paintings are considered entities by the server. But this should just.. prevent them from existing entirely, shouldn't it? I'm unsure of the cause, this wasn't happening before. :s

StonedGoat commented 1 month ago

Update: This appears to occur repeatedly, as several more of my graffitis disappeared today. I won't even be able to put a proper sign on my restaurant at this rate.

Luke100000 commented 1 month ago

I can't spot anything suspcicious in the server log and the client log is empty :(

StonedGoat commented 1 month ago

Shhiiit. is there anything else i might be able to provide? i know it's primarily meant for lag but i imagine running a spark profile, since they're considered entities, might help.

StonedGoat commented 1 month ago

Actually, thinking about it, would the modlist and any recently added things help? We recently tried adding Spawn Balance Utilities (SBU), but it seemingly did nothing so instead of removing it outright and risking damage I disabled every value it offered for functionalities.

StonedGoat commented 1 month ago

well, i don't know if it's helpful at all, but i ran a brief profiler. i was already logged out so idon't know how much it'll provide here

but i noticed one thing.

theres like.. ~20 paintings/graffiti active at all times, near spawn chunks. https://spark.lucko.me/k5vllK5ukY

there is one house full of them, and i guess it's close enough to spawn that it's considered a spawn chunk and loaded at all times :v

StonedGoat commented 1 month ago

another small update, sorry to spam in the comments a bit

it doesn't appear to be strictly linked to logging out? either that or a chunk loader i placed is helping somehow, but theres a couple i intentionally set outside the chunk as a test and its still there too.. its very unusual.

Luke100000 commented 1 month ago

Generally I know of 4 possible outcomes

One experiment you can try without causing much damage: rename the caches (both client and server) immersive_painting_cache to old_cache or something. There were funny errors in the past related to the cache.

StonedGoat commented 1 month ago

Alright, I just tried doing that and I'll report back shortly if it seems to work or not, but in the meantime, is there anything else I might be able to do? I'm willing to try alot, as the server is within my control, so if need be I can make backups to try more "risky" options.

Edit, found something in my logs that may or may not be related? I have no idea if this is a concern or not, but I spotted this.

[14:49:39] [main/WARN]: Reference map 'immersive_paintings-common-refmap.json' for immersive_paintings.mixin.json could not be read. If this is a development environment you can ignore this message

StonedGoat commented 1 month ago

alright, so the cache thing definitely didn't work. I'm also like 99% sure it's not related to logging out, it seems to happen when the chunks aren't loaded? I just ran around doing a bunch of misc stuff, back and forth from the area with some of these images too, and checked on my test board. Several images are missing again. I'm thinking it may be related to the chunks unloading.

I'm going to try running a chunkloader and see if it keeps them around.

StonedGoat commented 1 month ago

alright so, as it stands, it appears it's related to the chunks unloading? i'm not exactly sure, but using a chunkloader for the last 45 minutes seems to have made the items stay there.

i'm going to leave this open since this is still technically an issue, and this is just more of a workaround, so hopefully you can figure out what's wrong at some point later down the line, as this could affect others in the future.

if there's ANYTHING i can provide that might help further, just let me know.

edit: even weirder, i just noticed something.. the chunk loader wasnt in the chunk that the images were in. i'm so confused.

maybe it was affected by being next to it? idk.